zaheer - in flumotion/trunk: . flumotion/common

[flumotion-commit at lists.fluendo.com]

Author: zaheer
Date: Tue Jan 23 13:04:30 2007
New Revision: 4427

Modified:
   flumotion/trunk/ChangeLog
   flumotion/trunk/flumotion/common/worker.py
Log:
2007-01-23  Zaheer Abbas Merali  <zaheerabbas at merali dot org>

        * flumotion/common/worker.py:
        Appease pychecker and make comment.



Modified: flumotion/trunk/ChangeLog
==============================================================================
--- flumotion/trunk/ChangeLog	(original)
+++ flumotion/trunk/ChangeLog	Tue Jan 23 13:04:30 2007
@@ -1,3 +1,8 @@
+2007-01-23  Zaheer Abbas Merali  <zaheerabbas at merali dot org>
+
+	* flumotion/common/worker.py:
+	Appease pychecker and make comment.
+
 2007-01-23  Sebastien Merle  <sebastien at fluendo.com>
 
 	* flumotion/component/component.py: 

Modified: flumotion/trunk/flumotion/common/worker.py
==============================================================================
--- flumotion/trunk/flumotion/common/worker.py	(original)
+++ flumotion/trunk/flumotion/common/worker.py	Tue Jan 23 13:04:30 2007
@@ -57,7 +57,13 @@
         # status.value.status is the os.WAIT-like status value
         message = None
         obj = self.loggable
-        pid = (self.pid or "unknown") or str(self.pid)
+        pid = None
+        # if we have a pid, then set pid to string value of pid
+        # otherwise set to "unknown"
+        if self.pid:
+            pid = str(self.pid)
+        else:
+            pid = "unknown"
         if status.value.exitCode is not None:
             obj.info("Reaped child with pid %s, exit value %d.",
                      pid, status.value.exitCode)