thomasvs - in flumotion/trunk: . flumotion/ui

flumotion-commit at lists.fluendo.com flumotion-commit at lists.fluendo.com
Tue Feb 27 12:47:59 CET 2007


Hi!

On Tue, 2007-02-27 at 12:07 +0100, Thomas Vander Stichele wrote:
> > flumotion-flowtester.
> 
> Ah, where does that live then ? I searched flumotion and flumotion-fsp
> for callers and didn't find it.

In public svn, in its own module. I assume you also searched
ground-control from the private module as well.

> The reason I removed it is two-fold - no callers and no docs or
> comments.  If we put it back, will you address the second ? I hate going
> through all this stuff and finding 99% is uncommented and not
> understandable to someone not having seen that code before.

I might understand this if it actually had no callers. Regarding
comments... I think the idea "decorator"+"blocked signals" is fairly
clear. It decorates a method such that when it is called, signals are
blocked on that widget, unblocking either on return or on exception.
However if you really want I can spend some time to add some comments.

Andy.



More information about the flumotion-commit mailing list