zaheer - in flumotion/trunk: . flumotion/component flumotion/manager

[flumotion-commit at lists.fluendo.com]

On 2/14/07, flumotion-commit at lists.fluendo.com
<flumotion-commit at lists.fluendo.com> wrote:
> On Wed, 2007-02-14 at 18:32 +0100, flumotion-commit at lists.fluendo.com
> wrote:
> > Author: zaheer
> > Date: Wed Feb 14 18:32:02 2007
> > New Revision: 4488
> >
> > Modified:
> >    flumotion/trunk/ChangeLog
> >    flumotion/trunk/flumotion/component/feedcomponent010.py
> >    flumotion/trunk/flumotion/manager/component.py
> > Log:
> > 2007-02-14  Zaheer Abbas Merali  <zaheerabbas at merali dot org>
> >
> >         * flumotion/component/feedcomponent010.py:
> >         If we get a gstreamer error, errback any stateChangeDefers for
> >         READY->PAUSED.  This fixes issue where we do not errback on
> >         providing master clock.
>
> This looks like a nice way to fix the problem, but you've special-cased
> it a bit too much...
>
> Can you change this to errback any state change deferreds that are still
> pending?
> That should be:
>  - all upwards statechanges
>  - all downwards statechanges from a state higher than the current
> element state.
>
> Thanks,
>
> Mike
>
Agreed, I will do so.

Zaheer