[Elisa-commits] [MERGE] manager load providers only

[Benjamin Kampmann]

Olivier Tilloy schrieb:
 [...]
>> === modified file 'elisa-core/elisa/core/application.py'
>> --- elisa-core/elisa/core/application.py	2008-04-15 14:14:35 +0000
>> +++ elisa-core/elisa/core/application.py	2008-04-17 11:19:54 +0000
>> @@ -335,60 +335,41 @@
>>          return path
>>  
>>      [...]
>> +        """
>> +        Load the providers for the different managers, then initialize the
>> +        interface_controller.
>> +        """
>> +        # we want to load the providers and then initialize the player and the
>> +        # interface controller
>> +
>> +        def loading_providers_done(result):
>>              # close the splash screen right before loading the context
>>              self._close_splash_screen()
>>              self.interface_controller.initialize()
>> +            # after all that is done we send the ComponentsLoadedMessage
>>              self.bus.send_message(ComponentsLoadedMessage())
>> +        
>> +        managers = (  #  manager , option in the config file
>> +                    ( self.service_manager, 'service_providers'),
>> +                    ( self.metadata_manager, 'metadata_providers'),
>> +                    ( self.media_manager, 'media_providers'),
>> +                    ( self.resource_manager, 'resource_providers'),
>> +                   )
> 
> Could the order in which the managers are initialized and the providers
> loaded be a problem in some cases? I'm just wondering whether the
> resource providers should not be loaded before the metadata providers...
No Problem. This is only about *loading* the providers for a certain manager. The manager itself
is alreay up and working (application.metadata_manager for e.g.). Everyone can call
application.metadata_manager.register_component already.


>> === modified file 'elisa-core/elisa/core/manager.py'
>> --- elisa-core/elisa/core/manager.py	2008-04-15 10:29:42 +0000
>> +++ elisa-core/elisa/core/manager.py	2008-04-17 11:25:23 +0000
>> @@ -22,8 +22,6 @@
>>  __maintainer__ = 'Philippe Normand <philippe at fluendo.com>'
>>  
>>  [...]
>>  
>> @@ -138,7 +125,7 @@
>>      def component_registered(self, component):
>>          """ Check if a component is registed in the Manager or not
>>  
>> -        @param component: the Component to register
>> +        @param component: the Component to check fo
> 
> There's a typo here in the docstring, I guess you mean "the Component to
> check *for*".
> 
>>  [...]
> 
> Two of the four unit tests for the elisa.core.application module are in
> a [SKIPPED] state. I didn't look further into this, is it normal?
Didn't touch it. The tests of application need to be refactored anyway.

I also dropped the component_registered as discussed.

I'll merge it right now. Thanks for reviewing.
benjamin