[Elisa-commits] [MERGE] resource providers API and manager
Olivier Tilloy
olivier at fluendo.com
Fri Apr 11 13:33:30 CEST 2008
The code looks fine to me, I only have a few remarks about the
documentation:
elisa-core/elisa/core/resource_manager.py: not fully documented (no
module description, missing docstrings)
elisa-core/elisa/core/tests/test_resource_manager.py: same remark, no
docstrings at all, each testcase should document what it is supposed to
test...
These are not showstoppers for a merge, but remember that we want to
attract contributors, we've been promising them a brand new architecture
fully documented, let's start now. In most cases the code is
self-explanatory, but contributors don't necessarily want to dig into
the code to understand the API.
bb:tweak
Olivier
Benjamin Kampmann wrote:
> This merge request contains a totally reworked ResourceManagerTest.
> Beside this it contains the source_model changes as discussed and the
> smaller things Alessandro didn't find so charming ;) .
>
> I didn't touch the patch for application and removed the test for the
> base_component (as it is totally useless today).
More information about the Elisa-commits
mailing list